Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Fix failing Netlify build #14104

Closed

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Aug 5, 2024

After experimenting with different things in #13623 (you can see my commits if you're curious about what I tried), I managed to have the Netlify build working again.

I don't know what the origin of the issue is and why it's not reproducible locally after clearing the cache.

Testing:

  • I tested it in 56f5131 (#13623) and it fixed the failing build.
  • The ultimate test for this would be merging this PR and then merging master into one of the PRs that has the build failing

Other attempts

@cherniavskii cherniavskii added the scope: code-infra Specific to the core-infra product label Aug 5, 2024
@cherniavskii cherniavskii requested a review from a team August 5, 2024 13:28
@mui-bot
Copy link

mui-bot commented Aug 5, 2024

Deploy preview: https://deploy-preview-14104--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 55e6232

@JCQuintas
Copy link
Member

Did you have to do any change on @mui/monorepo/docs/pages/_document or it was simply copy/paste?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JCQuintas It's pure copy/paste from the latest next branch of the monorepo, not a single character changed:
https://github.com/mui/material-ui/blob/f9de2dd508b59623a99949f8891b96cf0016581c/docs/pages/_document.js

@cherniavskii cherniavskii marked this pull request as ready for review August 5, 2024 13:51
@LukasTy
Copy link
Member

LukasTy commented Aug 5, 2024

It looks like our Netlify config might not be ideal based on their doc and the following points from.

  1. If you are using yarn workspaces 14 or a monorepo 16 please consult the appropriate documentation (linked to in this sentence).
  2. Fairly rare but worth mentioning: You have a package.json in your repo root, but you are building a subdirectory of your repo and have NOT appropriately set the base directory in your build settings. That can lead to some confusing caching situations since we’ll only sometimes use that package.json (when there is nocache).

WDYT about trying this approach? 🤔
#14105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants