[charts] Add ChartsGrid to themeAugmentation
#13026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraleonte
added
typescript
enhancement
|
Deploy preview: https://deploy-preview-13026--material-ui-x.netlify.app/ |
JCQuintas
approved these changes
May 6, 2024
LukasTy
requested changes
May 6, 2024
| @@ -18,6 +18,10 @@ export interface ChartsComponents { | |||
| MuiChartsClipPath?: { | |||
| defaultProps?: ComponentsProps['MuiChartsClipPath']; | |||
| }; | |||
| MuiChartsGrid?: { | |||
| defaultProps?: ComponentsProps['MuiChartsGrid']; | |||
| styleOverrides?: ComponentsOverrides['MuiChartsGrid']; | |||
There was a problem hiding this comment.
Only the root slot/class seems to work, because only that one is present on the overridesResolver.
There was a problem hiding this comment.
Nitpick, the verticalLine and horizontalLine slots will still not do anything. 🙈
Consider applying the following diff to make them work:
diff --git a/packages/x-charts/src/ChartsGrid/ChartsGrid.tsx b/packages/x-charts/src/ChartsGrid/ChartsGrid.tsx
index f2d74db40..452083540 100644
--- a/packages/x-charts/src/ChartsGrid/ChartsGrid.tsx
+++ b/packages/x-charts/src/ChartsGrid/ChartsGrid.tsx
@@ -5,7 +5,11 @@ import { styled, useThemeProps } from '@mui/material/styles';
import { CartesianContext } from '../context/CartesianContextProvider';
import { useTicks } from '../hooks/useTicks';
-import { ChartsGridClasses, getChartsGridUtilityClass } from './chartsGridClasses';
+import {
+ ChartsGridClasses,
+ chartsGridClasses,
+ getChartsGridUtilityClass,
+} from './chartsGridClasses';
const GridRoot = styled('g', {
name: 'MuiChartsGrid',
@@ -16,7 +20,11 @@ const GridRoot = styled('g', {
const GridLine = styled('line', {
name: 'MuiChartsGrid',
slot: 'Line',
- overridesResolver: (props, styles) => styles.line,
+ overridesResolver: (props, styles) => [
+ { [`&.${chartsGridClasses.verticalLine}`]: styles.verticalLine },
+ { [`&.${chartsGridClasses.horizontalLine}`]: styles.horizontalLine },
+ styles.line,
+ ],
})(({ theme }) => ({
stroke: (theme.vars || theme).palette.divider,
shapeRendering: 'crispEdges',An example for reference:
mui-x/packages/x-date-pickers/src/DateTimePicker/DateTimePickerToolbar.tsx
Lines 215 to 218 in a3add0b
LukasTy
approved these changes
May 6, 2024
| @@ -18,6 +18,10 @@ export interface ChartsComponents { | |||
| MuiChartsClipPath?: { | |||
| defaultProps?: ComponentsProps['MuiChartsClipPath']; | |||
| }; | |||
| MuiChartsGrid?: { | |||
| defaultProps?: ComponentsProps['MuiChartsGrid']; | |||
| styleOverrides?: ComponentsOverrides['MuiChartsGrid']; | |||
There was a problem hiding this comment.
Nitpick, the verticalLine and horizontalLine slots will still not do anything. 🙈
Consider applying the following diff to make them work:
diff --git a/packages/x-charts/src/ChartsGrid/ChartsGrid.tsx b/packages/x-charts/src/ChartsGrid/ChartsGrid.tsx
index f2d74db40..452083540 100644
--- a/packages/x-charts/src/ChartsGrid/ChartsGrid.tsx
+++ b/packages/x-charts/src/ChartsGrid/ChartsGrid.tsx
@@ -5,7 +5,11 @@ import { styled, useThemeProps } from '@mui/material/styles';
import { CartesianContext } from '../context/CartesianContextProvider';
import { useTicks } from '../hooks/useTicks';
-import { ChartsGridClasses, getChartsGridUtilityClass } from './chartsGridClasses';
+import {
+ ChartsGridClasses,
+ chartsGridClasses,
+ getChartsGridUtilityClass,
+} from './chartsGridClasses';
const GridRoot = styled('g', {
name: 'MuiChartsGrid',
@@ -16,7 +20,11 @@ const GridRoot = styled('g', {
const GridLine = styled('line', {
name: 'MuiChartsGrid',
slot: 'Line',
- overridesResolver: (props, styles) => styles.line,
+ overridesResolver: (props, styles) => [
+ { [`&.${chartsGridClasses.verticalLine}`]: styles.verticalLine },
+ { [`&.${chartsGridClasses.horizontalLine}`]: styles.horizontalLine },
+ styles.line,
+ ],
})(({ theme }) => ({
stroke: (theme.vars || theme).palette.divider,
shapeRendering: 'crispEdges',An example for reference:
mui-x/packages/x-date-pickers/src/DateTimePicker/DateTimePickerToolbar.tsx
Lines 215 to 218 in a3add0b
1 task
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it's intentional or not, but came across this issue here.