Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix rows not being recomputed on props.rowCount change #12833

Merged
merged 1 commit into from
May 2, 2024
Merged

[DataGrid] Fix rows not being recomputed on props.rowCount change #12833

merged 1 commit into from
May 2, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Apr 18, 2024 •
edited
Loading

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: State management Related to the data grid State management feature labels Apr 18, 2024
@mui-bot
Copy link

mui-bot commented Apr 18, 2024

Deploy preview: https://deploy-preview-12833--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ba4124b

MBilalShafi added a commit to MBilalShafi/test-mui-x-12833 that referenced this pull request Apr 22, 2024
@MBilalShafi
Test mui/mui-x#12833
0d0a03c
@MBilalShafi MBilalShafi mentioned this pull request Apr 22, 2024
Closed
@MBilalShafi MBilalShafi marked this pull request as ready for review April 29, 2024 18:14
@cherniavskii
Copy link
Member

Before: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-dt6nxy
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-v4x3jd

@MBilalShafi Can you confirm the behavior in the "After" demo is correct?

@MBilalShafi
Copy link
Member Author

Yes, it looks correct.
Thanks @cherniavskii for creating the sandboxes.

michelengelen
michelengelen approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MBilalShafi MBilalShafi merged commit bb57c87 into mui:master May 2, 2024
20 checks passed
@MBilalShafi MBilalShafi deleted the fix-skeleton-rows-recompute branch May 2, 2024 11:18
@Crihojames Crihojames mentioned this pull request Jun 1, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@MBilalShafi @DungTiger
[DataGrid] Fix rows not being recomputed on props.rowCount change (m…
6ad00c9 
…ui#12833)
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@MBilalShafi @thomasmoon
[DataGrid] Fix rows not being recomputed on props.rowCount change (m…
ac88847 
…ui#12833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@romgrk romgrk Awaiting requested review from romgrk

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: State management Related to the data grid State management feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Delayed rows replaced with lazy loading, can't remove loading skeleton rows
4 participants
@MBilalShafi @mui-bot @cherniavskii @michelengelen