-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Change GridColDef
methods signatures
#11573
[DataGrid] Change GridColDef
methods signatures
#11573
Conversation
Deploy preview: https://deploy-preview-11573--material-ui-x.netlify.app/ Updated pages: |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I have measured the performance impact of this PR on quick filtering by measuring the execution time of the
I'm not 100% if it's worth pushing forward, because:
@romgrk @joserodolfofreitas What do you think? |
I'm still for these changes because:
|
GridColDef
methods signatureGridColDef
methods signatures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement 🚀
I think it makes sense to add these changes to the migration guide too
packages/grid/x-data-grid-premium/src/models/gridGroupingValueGetter.ts
Outdated
Show resolved
Hide resolved
packages/grid/x-data-grid/src/hooks/features/rows/useGridParamsApi.ts
Outdated
Show resolved
Hide resolved
Open a new issue for assistance. |
Closes #10741
Changelog
Breaking changes
The signature of
GridColDef['valueGetter']
has been changed for performance reasons:The
GridValueGetterParams
interface has been removed:The signature of
GridColDef['valueFormatter']
has been changed for performance reasons:The
GridValueFormatterParams
interface has been removed:The signature of
GridColDef['valueSetter']
has been changed for performance reasons:The
GridValueSetterParams
interface has been removed:The signature of
GridColDef['valueParser']
has been changed for performance reasons:The signature of
GridColDef['colSpan']
has been changed for performance reasons:The signature of
GridColDef['pastedValueParser']
has been changed for performance reasons:The signature of
GridColDef['groupingValueGetter']
has been changed for performance reasons: