Code review: Lukas

mui · Nov 3, 2022 · ce228da · ce228da
1 parent fc449bf
commit ce228da
Show file tree

Hide file tree

Showing 13 changed files with 32 additions and 0 deletions.
diff --git a/packages/x-date-pickers-pro/src/MultiInputDateRangeField/MultiInputDateRangeField.tsx b/packages/x-date-pickers-pro/src/MultiInputDateRangeField/MultiInputDateRangeField.tsx
@@ -166,6 +166,9 @@ MultiInputDateRangeField.propTypes = {
    * @default false
    */
   disablePast: PropTypes.bool,
+  /**
+   * Format of the date when rendered in the input(s).
+   */
   format: PropTypes.string,
   /**
    * Maximal selectable date. @DateIOType

diff --git a/...ages/x-date-pickers-pro/src/MultiInputDateTimeRangeField/MultiInputDateTimeRangeField.tsx b/...ages/x-date-pickers-pro/src/MultiInputDateTimeRangeField/MultiInputDateTimeRangeField.tsx
@@ -188,6 +188,9 @@ MultiInputDateTimeRangeField.propTypes = {
    * @default false
    */
   disablePast: PropTypes.bool,
+  /**
+   * Format of the date when rendered in the input(s).
+   */
   format: PropTypes.string,
   /**
    * Maximal selectable date. @DateIOType

diff --git a/packages/x-date-pickers-pro/src/MultiInputTimeRangeField/MultiInputTimeRangeField.tsx b/packages/x-date-pickers-pro/src/MultiInputTimeRangeField/MultiInputTimeRangeField.tsx
@@ -178,6 +178,9 @@ MultiInputTimeRangeField.propTypes = {
    * @default false
    */
   disablePast: PropTypes.bool,
+  /**
+   * Format of the date when rendered in the input(s).
+   */
   format: PropTypes.string,
   /**
    * Max time acceptable time.

diff --git a/packages/x-date-pickers-pro/src/SingleInputDateRangeField/SingleInputDateRangeField.tsx b/packages/x-date-pickers-pro/src/SingleInputDateRangeField/SingleInputDateRangeField.tsx
@@ -79,6 +79,9 @@ SingleInputDateRangeField.propTypes = {
    * @default false
    */
   disablePast: PropTypes.bool,
+  /**
+   * Format of the date when rendered in the input(s).
+   */
   format: PropTypes.string,
   /**
    * Maximal selectable date. @DateIOType

diff --git a/packages/x-date-pickers/src/DateField/DateField.tsx b/packages/x-date-pickers/src/DateField/DateField.tsx
@@ -79,6 +79,9 @@ DateField.propTypes = {
    * @default false
    */
   disablePast: PropTypes.bool,
+  /**
+   * Format of the date when rendered in the input(s).
+   */
   format: PropTypes.string,
   /**
    * Maximal selectable date. @DateIOType

diff --git a/packages/x-date-pickers/src/DateTimeField/DateTimeField.tsx b/packages/x-date-pickers/src/DateTimeField/DateTimeField.tsx
@@ -89,6 +89,9 @@ DateTimeField.propTypes = {
    * @default false
    */
   disablePast: PropTypes.bool,
+  /**
+   * Format of the date when rendered in the input(s).
+   */
   format: PropTypes.string,
   /**
    * Maximal selectable date. @DateIOType

diff --git a/packages/x-date-pickers/src/DesktopNextDatePicker/DesktopNextDatePicker.tsx b/packages/x-date-pickers/src/DesktopNextDatePicker/DesktopNextDatePicker.tsx
@@ -146,6 +146,7 @@ DesktopNextDatePicker.propTypes = {
   fixedWeekNumber: PropTypes.number,
   /**
    * Format of the date when rendered in the input(s).
+   * Defaults to localized format based on the used `views`.
    */
   format: PropTypes.string,
   /**

diff --git a/packages/x-date-pickers/src/MobileNextDatePicker/MobileNextDatePicker.tsx b/packages/x-date-pickers/src/MobileNextDatePicker/MobileNextDatePicker.tsx
@@ -144,6 +144,7 @@ MobileNextDatePicker.propTypes = {
   fixedWeekNumber: PropTypes.number,
   /**
    * Format of the date when rendered in the input(s).
+   * Defaults to localized format based on the used `views`.
    */
   format: PropTypes.string,
   /**

diff --git a/packages/x-date-pickers/src/NextDatePicker/NextDatePicker.tsx b/packages/x-date-pickers/src/NextDatePicker/NextDatePicker.tsx
@@ -108,6 +108,7 @@ NextDatePicker.propTypes = {
   fixedWeekNumber: PropTypes.number,
   /**
    * Format of the date when rendered in the input(s).
+   * Defaults to localized format based on the used `views`.
    */
   format: PropTypes.string,
   /**

diff --git a/packages/x-date-pickers/src/TimeField/TimeField.tsx b/packages/x-date-pickers/src/TimeField/TimeField.tsx
@@ -89,6 +89,9 @@ TimeField.propTypes = {
    * @default false
    */
   disablePast: PropTypes.bool,
+  /**
+   * Format of the date when rendered in the input(s).
+   */
   format: PropTypes.string,
   /**
    * Max time acceptable time.

diff --git a/packages/x-date-pickers/src/internals/hooks/useField/useField.interfaces.ts b/packages/x-date-pickers/src/internals/hooks/useField/useField.interfaces.ts
@@ -33,6 +33,9 @@ export interface UseFieldInternalProps<TValue, TError> {
    * The default value. Use when the component is not controlled.
    */
   defaultValue?: TValue;
+  /**
+   * Format of the date when rendered in the input(s).
+   */
   format: string;
   /**
    * It prevents the user from changing the value of the field

diff --git a/packages/x-date-pickers/src/internals/hooks/useField/useField.ts b/packages/x-date-pickers/src/internals/hooks/useField/useField.ts
@@ -98,6 +98,10 @@ export const useField = <
         return;
       }
 
+      if (selectedSectionIndexes != null) {
+        return;
+      }
+
       if (Number(input.selectionEnd) - Number(input.selectionStart) === input.value.length) {
         setSelectedSections({ startIndex: 0, endIndex: state.sections.length - 1 });
       } else {

diff --git a/packages/x-date-pickers/src/internals/models/props/basePickerProps.tsx b/packages/x-date-pickers/src/internals/models/props/basePickerProps.tsx
@@ -71,6 +71,7 @@ export interface BaseNextPickerProps<TValue, TDate, TView extends CalendarOrCloc
 export interface BaseNextNonStaticPickerProps {
   /**
    * Format of the date when rendered in the input(s).
+   * Defaults to localized format based on the used `views`.
    */
   format?: string;
 }