[Dialog] Allow fullWidth option of false #9724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
previously requested changes
Jan 4, 2018
oliviertassinari
added
the
component: dialog
oliviertassinari
approved these changes
Jan 4, 2018
|
Sorry, I gotta start remembering about the Typescript changes when I do these PR's. Thank you |
|
@gregnb Thank you :) |
mbrookes
reviewed
Jan 4, 2018
| @@ -155,9 +152,9 @@ Dialog.propTypes = { | |||
| * Determine the max width of the dialog. | |||
| * The dialog width grows with the size of the screen, this property is useful | |||
| * on the desktop where you might need some coherent different width size across your | |||
| * application. | |||
| * application. Set 'false' to turn off. | |||
There was a problem hiding this comment.
"Set to false to disable maxWidth."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9721