Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomNavigation] Rename BottomNavigationButton to BottomNavigationAction #9692

Merged
merged 1 commit into from
Jan 1, 2018
Merged

[BottomNavigation] Rename BottomNavigationButton to BottomNavigationAction #9692

merged 1 commit into from
Jan 1, 2018

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Jan 1, 2018

This is for consistency with the spec, and with the upcoming SpeedDial component.
Motivated by: #9539 (comment)

Breaking change

Rename the BottomNavigationButton component

-import BottomNavigation, { BottomNavigationButton } from 'material-ui/BottomNavigation';
+import BottomNavigation, { BottomNavigationAction } from 'material-ui/BottomNavigation';

…ction

This is for consistency with the spec, and with the upcoming SpeedDial component.

#9539 (comment)
@mbrookes mbrookes added breaking change component: bottom navigation This is the name of the generic UI component, not the React module! labels Jan 1, 2018
@oliviertassinari oliviertassinari changed the title [BottomNavigation] Rename BottomNavigationButton to BottomNavigationA… [BottomNavigation] Rename BottomNavigationButton to BottomNavigationAction Jan 1, 2018
@oliviertassinari oliviertassinari merged commit 28ec506 into mui:v1-beta Jan 1, 2018
@oliviertassinari
Copy link
Member

@mbrookes Good job :)

@mbrookes mbrookes deleted the bottom-nav-rename-button branch January 20, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: bottom navigation This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants