[Popover] New transition property #9682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
breaking change
component: menu
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
popover-add-transition
branch
from
8b20c1e to
a0f80f4
Compare
oliviertassinari
added
component: Popover
oliviertassinari
force-pushed
the
popover-add-transition
branch
from
a0f80f4 to
2b96f94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is allowing people to provide their own transition component to the Popover and the components that depend on it, like the Menu.
I have noticed this issue working on #9570. For instance, Vuetify provides this feature: https://next.vuetifyjs.com/components/menus#example-custom-transition
Breaking change:
transitionClassesproperty of the Popover component, instead, people can provide their own transition component.