[Table] Introduce padding property #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Table/TableCell.js
Outdated
| @@ -4,24 +4,22 @@ import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import type { ElementType, Node } from 'react'; | |||
| import classNames from 'classnames'; | |||
| import deprecated from 'prop-types-extra/lib/deprecated'; | |||
There was a problem hiding this comment.
Please, let's avoid the depreciation. Introducing breaking changes without deprecations save maintainer times.
|
I originally wanted to minimise changes but have also renamed compact -> dense across the class. Removed deprecations etc. Do you want api doc updates as part of PRs or do you do them seperately? |
oliviertassinari
approved these changes
Sep 24, 2017
oliviertassinari
changed the title
|
@eyn Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes