Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Don't set height to tbody #7484

Merged
merged 2 commits into from
Jul 20, 2017
Merged

[Table] Don't set height to tbody #7484

merged 2 commits into from
Jul 20, 2017

Conversation

GAumala
Copy link

@GAumala GAumala commented Jul 20, 2017 •
edited by oliviertassinari
Loading

Since the height of the table component is already set elsewhere
it is no longer necessary to set it the tbody tag.

Closes #5721

Before

Table height: 500px
ff-before-500

After

Table height: 500px
ff-after-500

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@GAumala
[Table] Don't set height to tbody
d1b02d8 
fixes mui#5721. Since the height of the table component is already set elsewhere
it is no longer necessary to set it the tbody tag.
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jul 20, 2017
@oliviertassinari oliviertassinari added the component: table This is the name of the generic UI component, not the React module! label Jul 20, 2017
@oliviertassinari oliviertassinari merged commit e481689 into mui:master Jul 20, 2017
djbuckley added a commit to manchesergit/material-ui that referenced this pull request Jul 24, 2017
@djbuckley
Merge remote-tracking branch 'call_em_all_-_master/master' (issue #148)
86d26f2 
* call_em_all_-_master/master:
  fix: comment typo (mui#7523)
  [Docs] Add v0.18.7 to versions.json
  v0.18.7
  [CHANGELOG] Prepare v0.18.7
  [ListItem] Fix triggers onTouchTap when disabled (mui#7486)
  [Popover] Scroll Container issue (mui#7472)
  [Table] Don't set height to tbody (mui#7484)
  docs: fix typo in Avatar readme (mui#7478)

# Conflicts:
#	src/Popover/Popover.js
# merged both versions
adam187 added a commit to adam187/material-ui that referenced this pull request Nov 21, 2017
@adam187
Merge branch 'fix/broken-touch-scroll-on-nested-menu-items' into cust…
c64b9ad 
…om-build

* fix/broken-touch-scroll-on-nested-menu-items:
  [Menu] Ignore loosing focus on click away for item with menu items
  [examples] Remove browserify
  Fixes mui#7559 (mui#7560)
  [docs] Update ROADMAP (mui#7543)
  [Table] Row click on empty cell to not die in IE (mui#7520)
  Internal(EnhancedSwitch): fix checked prop (mui#7499)
  fix: comment typo (mui#7523)
  [Docs] Add v0.18.7 to versions.json
  v0.18.7
  [CHANGELOG] Prepare v0.18.7
  [ListItem] Fix triggers onTouchTap when disabled (mui#7486)
  [Popover] Scroll Container issue (mui#7472)
  [Table] Don't set height to tbody (mui#7484)
  docs: fix typo in Avatar readme (mui#7478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GAumala @oliviertassinari