[TextField/FormControl] dense implementation #7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l `input` classes
rosskevin
added
component: text field
| @@ -104,6 +104,9 @@ export const styleSheet = createStyleSheet('MuiInput', theme => { | |||
| '&:focus::-ms-input-placeholder': placeholderFormFocus, // Edge | |||
| }, | |||
| }, | |||
| inputDense: { | |||
| paddingTop: `${theme.spacing.unit / 2}px 0`, | |||
There was a problem hiding this comment.
It's the bug I referred to, just paddingTop adjustment.
| import React from 'react'; | ||
| import TextField from 'material-ui/TextField'; | ||
|
|
||
| export default function TextFieldMargin() { |
There was a problem hiding this comment.
I don't think that we need that regression test as we are also taking into account the demo of the documentation.
There was a problem hiding this comment.
Also, that seems incorrect, there is no visual variations between the 3 inputs:
There was a problem hiding this comment.
What about removing it?
There was a problem hiding this comment.
awesome, forgot about those accounting for regressions!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7358
The previous approach was using
marginFormto implement what the spec callednormalspacing, whereas the default was to omit the margins.denseby spec is more than our defaultnone, but less than specnormal.Breaking change removes
marginFormand replaces it withmargin: 'none' | 'dense' | 'normal', where the default ofnoneis unchanged.Also: