[Tab] SVG icon takes color from Icon's color props as well..

[RejinR]

This is an improvement on the pull request #7091..
The color can now be passed from the color prop also instead of just style.

[oliviertassinari]

I'm not sure to follow, what's the use case for that color property? I don't think it fit into the whole Material-UI API.

[RejinR]

Developers may not want the default white color to come by default to the icon.. So adding an option to change the color can help in customising their tab component to their liking if necessary..
So now we can mention the color prop by either including it in the style or by using the color prop that is defined for the Icon component..

[oliviertassinari]

This all logic is getting too much complex. I think that the correct fix is the following:

// If it's svg icon set color via props
if (icon.type.muiName === 'SvgIcon') {
  iconProps.color = icon.props.color || styles.root.color;
}

[oliviertassinari]

It would be perfect if you could add some unit test to ensure it.

[oliviertassinari]

I have figured out how to simplify this in #7131. Let me know what you think about it.