Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormGroup] Add spec #6404

Merged
merged 3 commits into from
Mar 21, 2017
Merged

[FormGroup] Add spec #6404

merged 3 commits into from
Mar 21, 2017

Conversation

agamrafaeli
Copy link
Contributor

@agamrafaeli agamrafaeli commented Mar 21, 2017 •
edited
Loading

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Kind of simple testing, but FormGroup is used in InteractiveList, Checkboxes and RadiogGroup its better if its spec-ed, and not just left there.

@agamrafaeli agamrafaeli changed the title Add spec for FormGroup [FormGroup] Add spec Mar 21, 2017
@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Mar 21, 2017
@oliviertassinari oliviertassinari added next test and removed PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 21, 2017
@oliviertassinari
Copy link
Member

That feels soo good to have high-quality PRs. We can just merge them.

@oliviertassinari oliviertassinari merged commit 0e4c8e8 into mui:next Mar 21, 2017
@agamrafaeli agamrafaeli deleted the spec-formgroup-add branch April 1, 2017 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agamrafaeli @oliviertassinari @muibot