Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Use material-ui-icons package #6390

Merged
merged 5 commits into from
Mar 20, 2017
Merged

[docs] Use material-ui-icons package #6390

merged 5 commits into from
Mar 20, 2017

Conversation

mbrookes
Copy link
Member

  • PR has tests / docs demo, and is linted.

  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".

  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

  • Replace local icons with packaged icons

  • Remove unneeded icons from src/svg-icons

  • Replace font-icon with SvgIcons in IconButtons

  • Replace uses of Icon with material-ui-icons (except Icon docs examples)

  • Update & expand Style > Icons doc page

@mbrookes mbrookes added docs Improvements or additions to the documentation next labels Mar 19, 2017
@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Mar 19, 2017
@@ -35,6 +35,7 @@
},
"dependencies": {
"marked": "^0.3.6",
"material-ui-icons": "^1.0.0-alpha.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not changing the webpack conf to use the icons on the repository?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear the maintenance cost of keeping up to date.

Copy link
Member Author

@mbrookes mbrookes Mar 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari - the icons aren't in the repository. I guess we could add them, but unless there's major change, there is no maintenance cost.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbrookes Alright, choose what you think is best 👍 .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simplest for now. We can always revisit it if it causes an unforseen problem.

@mbrookes
Copy link
Member Author

Any idea what's causing CircleCi to fail? Tests are passing locally (those that I can run at least). Unfortunately CircleCI just gives a busy spinner when I try to see what the problem is:

image

Much preferred Travis! 😄

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 20, 2017

✖ EnhancedTable

A visual regression test fails

@mbrookes
Copy link
Member Author

mbrookes commented Mar 20, 2017

@oliviertassinari I might need your help to get the visual regression tests working again on my machine. In the meantime, would you mind fixing whatever i broke for this PR? 😊

If you wanted to add the es6 icons to the repo at the same time, I'm fine with that on reflection, as it would mean we don't need to keep a separate copy of the icons used in components in src/svg-icons.

@oliviertassinari oliviertassinari merged commit 4111f8f into mui:next Mar 20, 2017
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 20, 2017

@mbrookes I'm updating the baseline. The sooner argos-ci will be on, the better. We will simply be able to accept the changes.

@mbrookes
Copy link
Member Author

We will simply be able to accept the changes.

That sounds ideal! 👍

@oliviertassinari oliviertassinari added PR: Review Accepted and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 20, 2017
@mbrookes mbrookes deleted the next-docs-svgicons branch January 20, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants