[Chip] Add tests for handleKeyDown for Chip module #6379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muibot
added
PR: Needs Review
PR: needs revision
agamrafaeli
changed the title
- Declared but unused variable - Trailing comma - Missing semi-colon - Not modified variables that should have const protection
mbrookes
added
component: chip
oliviertassinari
approved these changes
Mar 19, 2017
| const preventDefaultSpy = spy(); | ||
| const spaceKeydownEvent = { | ||
| preventDefault: preventDefaultSpy, | ||
| keyCode: 32, // keycode `space` |
There was a problem hiding this comment.
We could have been using
import keycode from 'keycode';
keycode('space');There was a problem hiding this comment.
That's actually a good idea. I'll put in a PR for this. 👍
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.