Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transitions] Fix an unknown property warning #6157

Merged
merged 1 commit into from
Feb 16, 2017
Merged

[transitions] Fix an unknown property warning #6157

merged 1 commit into from
Feb 16, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 15, 2017

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Fix the following warning. We have added the enterTransitionDuration and leaveTransitionDuration on the Slider component but forgotten the Fade one. I think that exposing the two customization by default is the right option as the spec require different values for them.

Warning: Unknown prop transitionDuration on

tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
in div (created by Paper)
in Paper (created by Dialog)
in Transition (created by Slide)
in Slide (created by Dialog)
in div (created by Modal)

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work next labels Feb 15, 2017
@oliviertassinari oliviertassinari merged commit d6e33c6 into mui:next Feb 16, 2017
@oliviertassinari oliviertassinari deleted the fix-warning branch February 16, 2017 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants