[docs] Add onTouchTap documentation for FlatButton #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shahrukh-Zindani
commented
Feb 14, 2017
•
Shahrukh-Zindani
commented
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
oliviertassinari
requested changes
Feb 14, 2017
muibot
added
PR: needs revision
|
My bad. Added primary documentation back. |
oliviertassinari
requested changes
Feb 14, 2017
src/FlatButton/FlatButton.js
Outdated
| * If true, colors button according to | ||
| * primaryTextColor from the Theme. | ||
| */ | ||
| */ |
src/FlatButton/FlatButton.js
Outdated
| @@ -76,9 +76,14 @@ class FlatButton extends Component { | |||
| /** @ignore */ | |||
| onTouchStart: PropTypes.func, | |||
| /** | |||
| * Callback function for when the element is selected via a touch tap. | |||
There was a problem hiding this comment.
Most of the time, we follow that template:
/**
* Callback function fired when the button is touch-tapped.
*
* @param {object} event TouchTap event targeting the button.
*/
onTouchTap: PropTypes.func,
oliviertassinari
added
docs
oliviertassinari
changed the title
src/FlatButton/FlatButton.js
Outdated
| * Callback function fired when the button is touch-tapped. | ||
| * | ||
| * @param {object} event TouchTap event targeting the button. | ||
| */ |
There was a problem hiding this comment.
Same wrong indentation.
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
oliviertassinari
approved these changes
Feb 17, 2017
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.