[FlatButton] Add fullWidth property #6135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shahrukh-Zindani
commented
Feb 14, 2017
•
Shahrukh-Zindani
commented
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
muibot
added
PR: Needs Review
PR: needs revision
|
@oliviertassinari Can you please help me with getting these checks passed to get my first pull request merged? |
oliviertassinari
requested changes
Feb 14, 2017
src/FlatButton/FlatButton.js
Outdated
| * Color of button when mouse hovers over. | ||
| */ | ||
|
|
oliviertassinari
approved these changes
Feb 15, 2017
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
oliviertassinari
changed the title
|
@Shahrukh-Zindani Thanks. First PR 👏 |
|
@oliviertassinari Thanks. I was just wondering why don't I see my name in the list of contributors after you merged the branch? |
|
They are sorted by number of contributions DESC. We have 500 contributors. You gonna need to contribute more to see your name 😛 |
|
Okay. Got it. I was just making sure as I don't even see my name at the bottom. So was wondering if I am following the process correctly. |
weiqingtoh
added a commit
to coursemology-collab/coursemology2
that referenced
this pull request
Mar 30, 2017
- react-intl left out to use jeremy's fork. - react-router has a major version change, requires a separate commit. - material-ui has minor changes which requires snapshot changes - see mui/material-ui#6135 mui/material-ui#6204
jchiam
pushed a commit
to coursemology-collab/coursemology2
that referenced
this pull request
Mar 31, 2017
- react-intl left out to use jeremy's fork. - react-router has a major version change, requires a separate commit. - material-ui has minor changes which requires snapshot changes - see mui/material-ui#6135 mui/material-ui#6204
zannager
added
the
component: button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.