[Menu] focus handling fix

[ArcanisCz]

Fixes #5186

My idea for proper behavior is, that Menu changes focus every time, mouse enters some of the children. This seems to be better that user can use keys after leaving menu instead of removing focus on mouse motion.

[oliviertassinari]

The proposed change is quite important. I don't have any opinion on it yet. I need to benchmark what other are doing.

[ArcanisCz]

Problem lies in usability on how to synchronize focus navigation (via keyboard, which changes focused elements) and hover navigation. Each of states, :hover :focus has some active (gray) backgroud. Which makes sense. But, when menu opens, they start mixing.

Menu opens, first item in list is focues (active). When you move your mouse, some other items are active (hover), but the focued one is active too (this is thing reported in #5186). Options which came to my mind were:

1. dont focus first item initially, then keyUp wil focus last, keydown will select first. But when you press keyXX and then move your mouse, issue still remains from user perspective. (this could be taken as a very rare use case, since user would probably use only mouse or only keyboard, not both)
2. When moving mouse inside menu at all, remove focus on focused item(s)
3. link focus state to hover state (this is what i picked as reasonable solution - when user mousehover on item which is direct child - list item, it switches focus to it)

[oliviertassinari]

I'm gonna post what Nathan was saying me offline regarding that issue. I'm not sure to understand the underlying implications.

i think i know the issue
this isn't the correct fix
it's my fault because I left something confusing -- selected style == focused style
it shouldn't show that focus style unless it was keyboard activated
so it's either being pre-selected (and that menu has no proper selection hooked up)
or the keyboard focus styles are showing
i'll have to check

[pjuke]

Any updates on this?

[oliviertassinari]

I'm closing that PR as has been inactive for quite some time. I'm not sure what's the best fix for that one. We still have the issue as a reference. @ArcanisCz Thanks for the PR!