[docs-infra] Fix dark mode flicker for API pages #45354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45354--material-ui.netlify.app/ Bundle size report |
|
I think you will need to decouple the toggle buttons like I did in the PR https://github.com/mui/material-ui/pull/41911/files#r1622051793 Otherwise the stats saving is done, but not the style modification. Such that you need to reload the page to switch from light to dark Capture.video.du.2025-02-19.09-29-04.mp4 |
Nice catch, updated. |
alexfauquette
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simplification of #41911 by apply
BrandingCssVarsProviderto theApiPagedirectly.This applies to all API pages with only a few changes.
The rest are fixes of incorrect styles declaration.