[blog] React 19 migration for MUI X #45348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
requested review from
joserodolfofreitas,
oliviertassinari,
cherniavskii,
alexfauquette,
mapache-salvaje and
alelthomas
Netlify deploy previewhttps://deploy-preview-45348--material-ui.netlify.app/ Bundle size report |
|
Nice! I haven't reviewed the post yet but I love to see this kind of "behind the scenes" content for the blog! 🙌 |
alelthomas
reviewed
Feb 18, 2025
There was a problem hiding this comment.
This is great @arminmeh 🎉 Just made some small suggestions for grammar/readability
Thanks @alelthomas |
alexfauquette
approved these changes
Feb 19, 2025
| We were lucky that we didn't have to change much in the source code, but a lot of changes had to be made to our tests because of the modifications related to [strict mode](https://react.dev/blog/2024/04/25/react-19-upgrade-guide#strict-mode-improvements) and [error reporting](https://react.dev/blog/2024/04/25/react-19-upgrade-guide#errors-in-render-are-not-re-thrown). | ||
| These changes caused a different call count for our spies and different console outputs, so we had to expect different values based on the React major. | ||
|
|
||
| `@mui/internal-test-utils` provides an export `reactMajor` that extracts the major version of the React version used in the test. |
There was a problem hiding this comment.
The goal is not to encourage them to use our internal-test-utils but to rewrite their own
Suggested change
| `@mui/internal-test-utils` provides an export `reactMajor` that extracts the major version of the React version used in the test. | |
| :::info | |
| To know which version of React is running, they provide a nice helper | |
| ```js | |
| import * as React from 'react'; | |
| const reactMajor = parseInt(React.version, 10); | |
| ``` | |
| ::: |
There was a problem hiding this comment.
Not sure if we need the actual snippet 🤔
alelthomas
approved these changes
Feb 20, 2025
cherniavskii
approved these changes
Feb 21, 2025
arminmeh
force-pushed
the
blog-post-r19
branch
from
a3d147d to
2ca669b
Compare
mapache-salvaje
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Two tiny style suggestions, otherwise I think this is ready to publish. Great job @arminmeh !
Co-authored-by: Ale <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
arminmeh
force-pushed
the
blog-post-r19
branch
from
2c4e1c2 to
7f0f735
Compare
arminmeh
added a commit
to arminmeh/material-ui
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview https://deploy-preview-45348--material-ui.netlify.app/blog/react-19-update/