[material-ui] Allow nested theme creation with vars
#45335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45335--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
added
the
needs cherry-pick
aarongarciah
approved these changes
Feb 18, 2025
siriwatknp
commented
Feb 18, 2025
siriwatknp
commented
Feb 18, 2025
Signed-off-by: Siriwat K <[email protected]>
siriwatknp
added a commit
to siriwatknp/material-ui
that referenced
this pull request
Feb 19, 2025
siriwatknp
added a commit
to siriwatknp/material-ui
that referenced
this pull request
Feb 20, 2025
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44429
closes #34278
Summary
If the theme is already created with CSS theme variables, don't throw the error.
Next step (separate PR), create a documentation for recommended approach of the nested theme with CSS variables.