[material-ui][InputLabel] Changed size prop value from normal to medium
#45235
Conversation
perkrlsn
force-pushed
the
input-label-size
branch
from
15739d7 to
e92e0cf
Compare
perkrlsn
force-pushed
the
input-label-size
branch
from
e92e0cf to
222959d
Compare
ZeeshanTamboli
changed the title
normal to mediumnormal to medium
ZeeshanTamboli
changed the title
normal to mediumnormal to medium
ZeeshanTamboli
added
package: material-ui
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
|
@DiegoAndai @aarongarciah Should we include this breaking change in v7? A similar PR was opened before (#36188). It’s just a prop value change for consistency. I've also added it to the v7 upgrade guide: https://deploy-preview-45235--material-ui.netlify.app/material-ui/migration/upgrade-to-v7/ What do you think? Worth including? |
|
@ZeeshanTamboli +1 for being consistent. |
|
@ZeeshanTamboli we should add a codemod, too |
@aarongarciah Added. |
There was a problem hiding this comment.
Looks good. Leaving the approval to @DiegoAndai since he's overseeing all of the v7 changes.
There was a problem hiding this comment.
Hey @perkrlsn and @ZeeshanTamboli, thanks for working on this. Looks good, just one final thing. May I ask you to also include the following things in the InputLabel section of the upgrade guide:
Mention the class change (Edit: The default class is not added 😅MuiInputLabel-normal->MuiInputLabel-medium)- Mention the codemod, similar to: https://next.mui.com/material-ui/migration/upgrade-to-v7/#:~:text=Use%20this%20codemod,to/folder%3E
From what I can tell the
InputLabelis the only component with a'small' | 'normal'size prop. Looking through the rest of components (albeit with a very rudimentary search) the standard seems to be'small' | 'medium'.This PR updates the propery for the
InputLabelto match other components.