Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Dashboard sidenav sroll #44876

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 28, 2024

A small fix while I was looking at why the INP on the dashboard page is poor,

SCR-20241228-pwtx

Reported in mui/mui-x#16018.


Before: https://mui.com/material-ui/getting-started/templates/dashboard/

Screen.Recording.2024-12-28.at.18.04.52.mov

After: https://deploy-preview-44876--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/

Screen.Recording.2024-12-28.at.18.05.01.mov

It uses https://ui.shadcn.com/docs/components/sidebar as inspiration.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer labels Dec 28, 2024
@mui-bot
Copy link

mui-bot commented Dec 28, 2024

Netlify deploy preview

https://deploy-preview-44876--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0609f5e

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙌

@siriwatknp siriwatknp merged commit dd69cf0 into mui:master Jan 13, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants