-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Bump react 19 in v5 #44720
[core] Bump react 19 in v5 #44720
Conversation
Netlify deploy preview
@material-ui/core: parsed: +0.16% , gzip: +0.26% Bundle size reportDetails of bundle changes (Toolpad) |
@aarongarciah do these errors sound familiar? https://app.circleci.com/pipelines/github/mui/material-ui/144516/workflows/f9d4bf5f-1cf1-453d-8cd4-91a2df77cf51/jobs/778084 I'll debug them tomorrow. I'm just checking in case you have already gone through them in the past 😅. It's working on master, so I don't know what's missing to cherry-pick. |
@DiegoAndai is it the same issue as mui/mui-x#15769 (comment)? Re the error in
|
@aarongarciah in case you want to review again, there has been a lot of changes since yesterday, but it's ready now 😅 Sorry for opening it so soon, but I had to work with the CI. I added more detail in the description about the changes included in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚛️🚀
Final backports from v6 to v5 required to bump to React 19
Cherry-picks:
Besides, there are some one-off changes:
@pigment-css/react
package, this package won't be released from here anymore, so there's no impact to end usersreact-spring
related warnings as it doesn't support React 19 yet, and we only use it for demos.