Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select][TextField] Fix screen reader from saying &ZeroWidthSpace #44631

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[Select][TextField] Fix screen reader from saying &ZeroWidthSpace #44631

merged 1 commit into from
Dec 4, 2024

Conversation

arishoham
Copy link
Contributor

@arishoham arishoham commented Dec 2, 2024 •
edited by oliviertassinari
Loading

This PR fixes #41515 which causes the screen reader to read "zero width space" on select components

issue shown here:
image

Before: https://mui.com/material-ui/react-select/#basic-select
After: https://deploy-preview-44631--material-ui.netlify.app/material-ui/react-select/#basic-select

@arishoham arishoham mentioned this pull request Dec 2, 2024
Closed
@mui-bot
Copy link

mui-bot commented Dec 2, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44631--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 10ef36f

@oliviertassinari oliviertassinari changed the title [material-ui][Select] Fix screen reader from saying &ZeroWidthSpace [Select] Fix screen reader from saying &ZeroWidthSpace Dec 2, 2024
@oliviertassinari oliviertassinari added the component: text field This is the name of the generic UI component, not the React module! label Dec 2, 2024
@oliviertassinari oliviertassinari changed the title [Select] Fix screen reader from saying &ZeroWidthSpace [text field] Fix screen reader from saying &ZeroWidthSpace Dec 2, 2024
@oliviertassinari oliviertassinari added component: select This is the name of the generic UI component, not the React module! accessibility a11y labels Dec 2, 2024
@oliviertassinari oliviertassinari mentioned this pull request Dec 2, 2024
Closed
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 2, 2024
@zannager zannager requested a review from mj12albert December 3, 2024 11:22
mnajdova
mnajdova approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix!

@arishoham
Copy link
Contributor Author

@mnajdova is there anything else i can/should do to get this merged?

@ZeeshanTamboli ZeeshanTamboli changed the title [text field] Fix screen reader from saying &ZeroWidthSpace [TextField] Fix screen reader from saying &ZeroWidthSpace Dec 4, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [TextField] Fix screen reader from saying &ZeroWidthSpace [Select][TextField] Fix screen reader from saying &ZeroWidthSpace Dec 4, 2024
@mj12albert mj12albert merged commit 6c6cb7e into mui:master Dec 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj12albert mj12albert mj12albert approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
accessibility a11y bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] "&ZeroWidthSpace" is being rendered as child element
5 participants
@arishoham @mui-bot @mnajdova @mj12albert @oliviertassinari