[docs-infra] Automatically hide Black Friday banner #44630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
1 task
Netlify deploy previewhttps://deploy-preview-44630--material-ui.netlify.app/ Bundle size report |
hasdfa
approved these changes
Dec 2, 2024
zanivan
approved these changes
Dec 2, 2024
oliviertassinari
commented
Dec 2, 2024
|
|
||
| function isBlackFriday() { | ||
| const today = Date.now(); | ||
| const start = new Date('2024-11-25').getTime(); |
There was a problem hiding this comment.
I merged this too quickly, it will create an hydration error and a CLS after the Black Friday date expires. Better have the layout shift during to draw people's attention.
There was a problem hiding this comment.
Handling it in #44632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regressions from #44565.
For the end date I used this https://github.com/mui/mui-private/blob/68478c35560439e13c946b8e8d6c0cb932f53632/web/src/modules/components/marketing/black-friday-2024/useBlackFriday2024.ts#L40