Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Tabs] Fix ScrollbarSize ref being overriden #44593

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Nov 28, 2024

Closes: #41388
The explanation for the fix: #41388 (comment)

ScrollbarSize is an internal component, not exported, and we don't need to provide a ref, so there's no need for ref merging.

Before and after: https://github.com/DiegoAndai/material-ui-issue-41388-repro
Before is the main branch
After is the with-fix branch that uses this PR's build

@DiegoAndai DiegoAndai added component: tabs This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material React 19 support PRs required to support React 19 labels Nov 28, 2024
@DiegoAndai DiegoAndai self-assigned this Nov 28, 2024
@mui-bot
Copy link

mui-bot commented Nov 28, 2024

Netlify deploy preview

https://deploy-preview-44593--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 3d4aa7f

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DiegoAndai DiegoAndai merged commit cdb03a5 into mui:master Nov 28, 2024
22 checks passed
@DiegoAndai DiegoAndai deleted the fix-scrollbarsize-ref branch November 28, 2024 13:38
DiegoAndai added a commit to DiegoAndai/material-ui that referenced this pull request Nov 28, 2024
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material React 19 support PRs required to support React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Tabs] Scrollable variant fails test when clicking the tab (error reading 'offsetHeight')
4 participants