Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove Black Friday from the notifications #44575

Closed
wants to merge 1 commit into from
Closed

[docs] Remove Black Friday from the notifications #44575

wants to merge 1 commit into from

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Nov 27, 2024

PR to remove Black Friday notification after Black Friday (#44566 (comment))

@zanivan zanivan added the docs Improvements or additions to the documentation label Nov 27, 2024
@zanivan zanivan self-assigned this Nov 27, 2024
@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait label Nov 27, 2024
@mui-bot
Copy link

mui-bot commented Nov 27, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44575--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c794693

@oliviertassinari
Copy link
Member

Not sure exactly when is the end of black Friday. I guess https://github.com/mui/mui-private/blob/cac03d470ee69ef7eb04172ecb44b0ec8d29ea39/web/src/modules/components/marketing/black-friday-2024/useBlackFriday2024.ts#L40.

@zanivan
Copy link
Contributor Author

zanivan commented Nov 27, 2024

Not sure exactly when is the end of black Friday. I guess https://github.com/mui/mui-private/blob/cac03d470ee69ef7eb04172ecb44b0ec8d29ea39/web/src/modules/components/marketing/black-friday-2024/useBlackFriday2024.ts#L40.

@oliviertassinari Maybe then we should change the Notification to "Cyber week" and we remove it after Dec 7th. Does that make sense?

@oliviertassinari
Copy link
Member

No objections, but it's maybe a time distraction, unclear 😄

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 2, 2024
@aarongarciah
Copy link
Member

The Black Friday notification was removed via #44629

@oliviertassinari oliviertassinari removed the on hold There is a blocker, we need to wait label Dec 27, 2024
@oliviertassinari oliviertassinari mentioned this pull request Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

@hasdfa hasdfa Awaiting requested review from hasdfa

Assignees

@zanivan zanivan

Labels
docs Improvements or additions to the documentation PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zanivan @mui-bot @oliviertassinari @aarongarciah