Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Copyedit Templates page #44461

Merged
merged 9 commits into from
Nov 20, 2024
Merged

[docs] Copyedit Templates page #44461

merged 9 commits into from
Nov 20, 2024

Conversation

mapache-salvaje
Copy link
Contributor

  • style guide
  • more context for free template features
  • more informative template descriptions
  • explain why you might try Toolpad Core if you land here

@mapache-salvaje mapache-salvaje added the docs Improvements or additions to the documentation label Nov 18, 2024
@mapache-salvaje mapache-salvaje marked this pull request as ready for review November 18, 2024 20:38
@mui-bot
Copy link

mui-bot commented Nov 18, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 70e0e89

@mapache-salvaje mapache-salvaje mentioned this pull request Nov 18, 2024
Merged
@zannager zannager requested a review from zanivan November 19, 2024 11:32
zanivan
zanivan approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for the improvement 🙌

Do you think we should mention somewhere that users can download the templates via CodeSandbox or StackBlitz? Either way, leaving my approval in advance.

@mapache-salvaje
Copy link
Contributor Author

Do you think we should mention somewhere that users can download the templates via CodeSandbox or StackBlitz?

Good call! I'll add that now.

@mapache-salvaje
Copy link
Contributor Author

@prakhargupta1 @bharatkashyap let me know what you think about the updated Toolpad copy here.

@bharatkashyap
Copy link
Member

@prakhargupta1 @bharatkashyap let me know what you think about the updated Toolpad copy here.

It makes sense @samuelsycamore - I've updated my PR to use what you've added here with slight modifications given that that PR removes the DashboardLayout demo and replaces it with a template. Feel free to merge this and I'll resolve conflicts in the other PR

@zanivan zanivan mentioned this pull request Nov 20, 2024
Merged
1 task
@mapache-salvaje mapache-salvaje merged commit 52376a1 into mui:master Nov 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mapache-salvaje @mui-bot @bharatkashyap @zanivan