Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Update backlink sponsors #43995

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

rluzists1
Copy link
Contributor

@rluzists1 rluzists1 commented Oct 4, 2024

@rluzists1 rluzists1 added the website Pages that are not documentation-related, marketing-focused. label Oct 4, 2024
@rluzists1 rluzists1 self-assigned this Oct 4, 2024
@mui-bot
Copy link

mui-bot commented Oct 4, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6c770eb

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/src/components/home/GoldSponsors.tsx Outdated Show resolved Hide resolved
docs/src/components/home/GoldSponsors.tsx Outdated Show resolved Hide resolved
docs/data/material/discover-more/backers/backers.md Outdated Show resolved Hide resolved
docs/data/material/discover-more/backers/backers.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 5, 2024
@oliviertassinari oliviertassinari force-pushed the change-backlink-gold-sponsors branch from dc2b030 to 61a7794 Compare October 5, 2024 12:56
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 5, 2024
@oliviertassinari oliviertassinari force-pushed the change-backlink-gold-sponsors branch 2 times, most recently from 2944ca0 to 4e59341 Compare October 5, 2024 13:04
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 5, 2024
@oliviertassinari oliviertassinari force-pushed the change-backlink-gold-sponsors branch from 4e59341 to fa9751a Compare October 5, 2024 13:30
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 5, 2024
@oliviertassinari oliviertassinari force-pushed the change-backlink-gold-sponsors branch 2 times, most recently from e734414 to 1769218 Compare October 5, 2024 13:34
moving Megafamous and Goread.io to backlink sponsors section on Read.ME, homepage and docs
@oliviertassinari oliviertassinari force-pushed the change-backlink-gold-sponsors branch from 1769218 to 6c770eb Compare October 5, 2024 13:36
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 5, 2024

I have tried to polish the existing sponsors and pushed those changes to HEAD directly.


I was wondering about the experience:

Sponsors page

Current:

SCR-20241005-nyir

A:
SCR-20241005-nwpg

B:
SCR-20241005-nxez

README

Current:
SCR-20241005-nwqr

A:
SCR-20241005-nwvs

B:
SCR-20241005-nxbe

"current" seems best. What could be ideal is maybe option A but with a bit larger logos. Something that feels less noticeable than in "current", but still bigger than in option A. I don't know. It doubt it will make much of a difference anyway, we can ignore this 👍

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise, it looks good :)


"current" seems best. What could be ideal is maybe option A but with a bit larger logos. Something that feels less noticeable than in "current", but still bigger than in option A. I don't know. It doubt it will make much of a difference anyway, we can ignore this 👍

I agree that the 'current' version looks better on the sponsors page in the docs, but it could be improved in the README. If I had to choose between A and B, I’d likely go with B, because showing only the smaller logos can feel like a different level of sponsorship, not a gold sponsor. That said, I wouldn’t change anything now, as I agree it won't make much of a difference either.

@rluzists1
Copy link
Contributor Author

nice, thanks both for the input @zanivan @oliviertassinari - I'm going to wait a couple more days to see if these sponsors reply to my message about the updates with any pushback, otherwise, will merge Wednesday morning 👍

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 7, 2024

@zanivan the problem I see with option B is that those links, standalone, draw too much attention, it feels like logos blend more into the rest of the page. Maybe if they were links with a lower font-weight, it would work great. On the opposite side with logos, we don't want people to feel like this: https://x.com/mitomenace/status/1789759204510622071

@rluzists1 rluzists1 merged commit 5567c56 into mui:master Oct 9, 2024
22 checks passed
@rluzists1 rluzists1 deleted the change-backlink-gold-sponsors branch October 9, 2024 08:17
@oliviertassinari
Copy link
Member

Great, this is clean 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants