[core] Fix eslint-plugin-react-compiler issues in usePagination tests #43946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
Netlify deploy previewhttps://deploy-preview-43946--material-ui.netlify.app/ Bundle size report |
|
Hello @aarongarciah ! Im new to opensource and want to do my first contribution to MUI! I saw an older thread from june (#42564), where I fixed an Eslint issue with usePagination.test.js file and did this PR. Uploaded the yaml file to fix circleci: checkout with pnpm deduplicate accoarding to CONTRIBUTE.md file. Is the PR ready for review or is there additional things to add? Thank you in advance! 😃 |
…Effect hook to update hook after execution, error: Writing to a variable defined outside a component or hook is not allowed. Consider using an effecteslint(react-compiler/react-compiler)
wilhelmlofsten
force-pushed
the
fixEslLintTestFile
branch
from
0304623
to
7316795
Compare
github-actions
bot
removed
the
PR: out-of-date
aarongarciah
changed the title
aarongarciah
approved these changes
Oct 1, 2024
Signed-off-by: Aarón García Hervás <[email protected]>
66 tasks
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed eslint issue with usePagination.test.js file by using React.useEffect hook to update hook after execution, error: Writing to a variable defined outside a component or hook is not allowed. Consider using an effecteslint(react-compiler/react-compiler).
Ran the test file and had 16 tests passed, so should work :)
Fix for the packages/mui-material/src/usePagination/usePagination.test.js file which the box was unchecked from issue #42564 , where issue #43117 still contained the eslint error.