[code-infra] Remove custom playwright installation steps #43881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43881--material-ui.netlify.app/ Bundle size report |
Janpot
changed the title
Janpot
changed the title
This was referenced Sep 25, 2024
This reverts commit b86516d.
JCQuintas
reviewed
Sep 27, 2024
| @@ -74,25 +73,15 @@ commands: | |||
| steps: | |||
| - run: | |||
| name: Install pnpm package manager | |||
| command: | | |||
| corepack enable | |||
| corepack prepare pnpm@latest-8 --activate | |||
There was a problem hiding this comment.
I suppose we dont need this anymore because we are defining it in the package.json?
There was a problem hiding this comment.
Yep, I don't even think it was ever needed.
JCQuintas
approved these changes
Sep 27, 2024
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43880
The caching currently is not working and fixing it decreases performance even more.
In fact it's not even necessary to install those browsers as we use the
mcr.microsoft.com/playwright:v1.47.1-focalimage which comes with the correct ones preinstalled, just have to remove the custom install location so playwright can find them instead of the ones we install after.We were basically:
This should reduce runtime of jobs that use a browser with ~40s
Also slightly cleaning up the corepack steps
To investigate next: is it possible to use the regular node image but with a playwright install step, and what would be the performance impact vs. using
mcr.microsoft.com/playwright:v1.47.1-focal? See #43883