[core] Replace toBeAriaHidden matcher with toBeInaccessible in tests
#43870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43870--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
deleted the
replace-toBeAriaHidden-with-toBeInaccessible
branch
ZeeshanTamboli
restored the
replace-toBeAriaHidden-with-toBeInaccessible
branch
ZeeshanTamboli
changed the title
toBeAriaHidden matcher with toBeInaccessible
ZeeshanTamboli
changed the title
toBeAriaHidden matcher with toBeInaccessibletoBeAriaHidden matcher with toBeInaccessible in tests
ZeeshanTamboli
commented
Sep 27, 2024
| for (let i = 1; i < numberOfChildren; i += 1) { | ||
| expect(container2.children[i]).not.toBeAriaHidden(); | ||
| expect(container2.children[i].getAttribute('aria-hidden')).to.equal(null); |
There was a problem hiding this comment.
Unique case where we cannot use .not.toBeInaccessible assertion. Some elements in the forbidden list like <template>, <script>, <style>, <noscript> etc are implicitly inaccessible in the accessibility tree due to display: 'none' being applied implicitly. Other elements like <map>, <col>, <colgroup> etc are accessible.
ZeeshanTamboli
deleted the
replace-toBeAriaHidden-with-toBeInaccessible
branch
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toBeAriaHiddenis marked as deprecated, so replaced it withtoBeInaccessible. This change makes sense sincetoBeInaccessiblechecks more than just thearia-hiddenattribute — it also accounts for other factors that determine if an element should be excluded from the accessibility tree. It uses the DOM Testing Library'sisInaccessiblemethod internally.Additionally,
toBeAriaHiddenhas been removed from the matchers list since it is not used in MUI X, Toolpad, or Pigment CSS.