[material-ui][Rating] Use Rating name as prefix of input element ids
#43829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43829--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
yash49
changed the title
name as prefix of generated id-sname as prefix of input element ids
ZeeshanTamboli
added
package: material-ui
ZeeshanTamboli
changed the title
name as prefix of input element idsname as prefix of input element ids
Sure, will add one & update the PR |
Co-authored-by: Zeeshan Tamboli <[email protected]> Signed-off-by: Yash Shah <[email protected]>
yash49
commented
Sep 27, 2024
@ZeeshanTamboli I've added the unit test. Let me know if anything needs an update. |
| // preventing one component from affecting another. React 18's useId already handles this. | ||
| // Update to const id = useId(); when React 17 support is dropped. | ||
| // More details: https://github.com/mui/material-ui/issues/40997 | ||
| const id = `${name}-${useId()}`; |
There was a problem hiding this comment.
I changed it to this since name will always be available either through provided prop or generated through useId below.
ZeeshanTamboli
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
Looks good! Thanks @yash49. I also fixed a typo in the API description.
|
Thanks @ZeeshanTamboli 🙌 |
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #40997