-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Sync React.version parse logic with codebase #43820
Merged
mnajdova
merged 1 commit into
mui:master
from
oliviertassinari:sync-react-version-parse
Sep 20, 2024
Merged
[test] Sync React.version parse logic with codebase #43820
mnajdova
merged 1 commit into
mui:master
from
oliviertassinari:sync-react-version-parse
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
sync-react-version-parse
branch
from
September 19, 2024 20:02
96dea1b
to
c186553
Compare
Netlify deploy previewhttps://deploy-preview-43820--material-ui.netlify.app/ Bundle size report |
sai6855
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
aarongarciah
approved these changes
Sep 20, 2024
mnajdova
approved these changes
Sep 20, 2024
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the rest of the codebase https://github.com/search?q=org%3Amui%20React.version&type=code. Seen in #43022 (comment).