[docs] Fix 301 to chromium #43809
Merged
[docs] Fix 301 to chromium #43809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
reviewed
Sep 19, 2024
| @@ -4,8 +4,6 @@ const IconRoot = styled('span')(({ | |||
| userSelect: 'none', | |||
| width: '1em', | |||
| height: '1em', | |||
| // Chrome fix for https://bugs.chromium.org/p/chromium/issues/detail?id=820541 | |||
There was a problem hiding this comment.
Is this not relevant anymore?
There was a problem hiding this comment.
We need to keep track of the status of each of these bugs. Once they are fixed and propagated enough with end users, we should update our implementation to take advantage of those fixes. I think it's important to stay relevant.
Now, this is a codemod file, I think removing this comment will make it easier to maintain those.
michaldudak
approved these changes
Sep 19, 2024
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.chromium.org/for-testers/faq/ for what happened.
I have noticed this while I was browsing the docs and curious about what a Chromium bug about text ellipse with flexbox was about. A quick win.