-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Remove position:relative from regression container #43743
[test] Remove position:relative from regression container #43743
Conversation
Netlify deploy previewhttps://deploy-preview-43743--material-ui.netlify.app/ Bundle size report |
flakyness of https://app.argos-ci.com/mui/material-ui/builds/32056/108822015 is not solved 😢 |
The first one is caused by the removal of |
@Janpot I updated the
before: the gradient background covers all of the demo surface, including the demo container padding. It overflows the rounded corners of the demo container. after: the demo is self contained, doesn't overflow the demo container. Not as beautiful as before. Ideally we should have a way of removing padding in specific demos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great
@Janpot But we have a cleaner screenshot environment at least 😄. Issue created to propagate it: mui/mui-public#199
@aarongarciah Nice, I tried #43748 to push it a step further. |
Follow up on #43656 (comment)
Preview: https://deploy-preview-43743--material-ui.netlify.app/material-ui/react-slider/#music-player