-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Skeleton] Fix wave animation for styled-components #43740
Conversation
Netlify deploy previewhttps://deploy-preview-43740--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Is the limitation of being unable to use css
in an object documented somewhere so Pigment CSS users are aware?
The issue is related to Styled-components, not Pigment CSS. I don't think we need to document this since styled-components already documented it. |
closes #43611
Root cause
The animation wrapped in
css
is used within an object. This is not allowed:The fix is to move the
&::after
inside thecss
:Note: I check the rest of the components that has animation, all of them are using the right approach.