[material-ui][docs] Document Typography color prop breaking change #43735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
docs
aarongarciah
commented
Sep 12, 2024
| @@ -360,6 +360,25 @@ As the `ListItem` no longer supports these props, the class names related to the | |||
|
|
|||
| In v6, the `children` prop passed to the Loading Button component is now wrapped in a `<span>` tag to avoid [issues](https://github.com/mui/material-ui/issues/27853) when using tools to translate websites. | |||
|
|
|||
| ### Typography | |||
There was a problem hiding this comment.
I decided to add a new entry since this is an undocumented breaking change.
DiegoAndai
approved these changes
Sep 13, 2024
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43589
We documented the deprecation of system props in the v6 upgrade guide: https://mui.com/material-ui/migration/migrating-from-deprecated-apis/#system-props. But we introduced a breaking change in the
colorprop of theTypographycomponent: it's not a system prop anymore, and thus it doesn't support callbacks to access the theme, responsive values, etc.This PR documents the breaking change.