[docs][material-ui][CircularProgress] Add Circular size demo #43734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Can we demonstrate Circular Progress with a non-pixel unit as well for the size prop? The size prop accepts both numbers (in pixels) and strings (with any CSS unit). We could show two examples using pixel values, and a third example using a string value to highlight that size supports CSS units other than pixels.
sai6855
force-pushed
the
circular-size
branch
from
77e5470
to
48b1352
Compare
|
@ZeeshanTamboli updated here 48b1352, what do you think? |
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we received feedback on slack on how to customize size of circular progress , this PR adds demo for it
demo: https://deploy-preview-43734--material-ui.netlify.app/material-ui/react-progress/#circular-size