Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add scrollbar to color picker demo #43672

Merged
merged 3 commits into from
Sep 11, 2024
Merged

[docs] Add scrollbar to color picker demo #43672

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b0902e
add scrollbar to demo
sai6855 Sep 9, 2024
cb82a00
Update docs/data/material/customization/color/ColorDemo.js
sai6855 Sep 11, 2024
cdfcb87
Merge branch 'master' into scroll-demo
ZeeshanTamboli Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/data/material/customization/color/ColorDemo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function ColorDemo(props) {
</Typography>
</Toolbar>
</AppBar>
<Box component="pre" sx={{ m: 2, fontSize: 16 }}>
<Box component="pre" sx={{ m: 2, fontSize: 16, overflowX: 'auto' }}>
Copy link
Member

@oliviertassinari oliviertassinari Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

Suggested change
<Box component="pre" sx={{ m: 2, fontSize: 16, overflowX: 'auto' }}>
<Box component="pre" sx={{ m: 2, fontSize: 16, overflow: 'auto' }}>

like in

material-ui/packages/mui-docs/src/MarkdownElement/MarkdownElement.tsx

Line 32 in 494c10c

overflow: 'auto',
?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do this. The reason I went for overflowX is that I haven't come across any situation that requires a scrollbar on the Y axis.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we can be lazy and wait. It's more that I usually never seen X/Y overflow to be superior to the alternatives: what I found most useful is nothing, or overflow: auto when I want to make sure a scroll container trigger.

{`{
palette: {
primary: ${primary.output},
Expand Down
Loading