[docs-infra] Fix axe issue scroll-to-top without landmark #43663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-43663--material-ui.netlify.app/ Bundle size report |
alexfauquette
approved these changes
Sep 9, 2024
oliviertassinari
changed the title
|
Alright, having this under cc @vladmoroz for context. I was initially against having something like this https://docs.github.com/en/get-started/using-github/connecting-to-github 
but it's kind of OK. If we look at the Google Analytics, it seems that this is not really used though. |
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick-win that I noticed. Opened a PR as seems more efficient than an issue. When running https://chromewebstore.google.com/detail/axe-devtools-web-accessib/lhdoppojpmngadmnindnejefpokejbdd?pli=1 on after scrolling a bit the page on https://mui.com/material-ui/react-button/ or any others. We get this:
which they explain in https://dequeuniversity.com/rules/axe/4.10/region?application=AxeChrome.
Related issue: https://www.drupal.org/project/back_to_top/issues/3254713. I think it matters because we want our component to have no error, so if the docs-infra has one, it creates noise.
Preview: https://deploy-preview-43663--material-ui.netlify.app/material-ui/react-button/