[docs-infra] Fix toolbar arrow order #43627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-43627--material-ui.netlify.app/ Bundle size report |
vladmoroz
approved these changes
Sep 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
Screen.Recording.2024-09-05.at.23.01.25.mov
Source: https://deploy-preview-477--base-ui.netlify.app/base-ui/react-field/#labeling-and-descriptive-help-text. I broke this in #40832. It's a quick win, so I thought I might open a PR, faster than open an issue. The logic itself could likely be improved using Base UI components, but for now, we use what https://github.com/eps1lon setup.
@vladmoroz since you will help with the docs, I thought I would give you an easy PR to review, to give a bit of an introduction of the docs-infra that we have 😄
Preview: https://deploy-preview-43627--material-ui.netlify.app/material-ui/react-button/#basic-button