-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Revert icon search virtualization #43569
Conversation
Netlify deploy previewhttps://deploy-preview-43569--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I don't understand, I would expect this to be smooth like in https://react.dev/reference/react/useDeferredValue#examples
but instead, once the full list of icons starts rendering, it never gets interrupted:
Screen.Recording.2024-09-03.at.00.49.07.mov
You can compare the input responsiveness with https://deploy-preview-43582--material-ui.netlify.app/material-ui/material-icons/ where I removed the deferred values. You don't even need to throttle CPU to notice the difference. Just type "a" and then backspace
I'm not sure I follow. How do you know it never gets interrupted just by looking at the UI? |
@Janpot Oh, ok, strange. I see it behaving as expected on the PR preview (prod mode) but not in dev mode. All the feedback that I left seems handled here. This looks like a clear step forward, I think it's much better 👍. I used the opportunity to remove a lot of After: https://pagespeed.web.dev/analysis/https-deploy-preview-43569--material-ui-netlify-app-material-ui-material-icons/ffwxi8dwji?form_factor=desktop |
a7418a1
to
a49d647
Compare
Revert icons page back to use deferred value only (as per #41330 (comment))
See #41330 (comment)
After: https://deploy-preview-43569--material-ui.netlify.app/material-ui/material-icons/
Fix #41126