-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Upgrade babel runtime #43243
[core] Upgrade babel runtime #43243
Conversation
Netlify deploy previewhttps://deploy-preview-43243--material-ui.netlify.app/ Bundle size report |
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Jan Potoms <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a setting to force using the installed version somehow? 🤔
My fear is that we sync it now, but after dependency bumping it will once again get out of sync. 🙈
I see two ways:
I don't think it's a huge problem if it goes out of sync though, the package will be backwards compatible within the same major. |
Looking into this separately. I found a package that is missing |
Was looking through our bundles to debug another issue, and noticed we were compiling in the
interopRequireWildcard
runtime helper instead of referencing it from@babel/runtime
. This upgrades the expected@babel/runtime
version to the one we depend on so that babel is up to date about which helpers are available and can use more of them.