Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] fix textarea maxRows #4286

Closed
wants to merge 2 commits into from
Closed

Conversation

loujiayu
Copy link

@loujiayu loujiayu commented May 17, 2016

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Limit the number of lines user is abel to enter in textarea.
#4276

@oliviertassinari
Copy link
Member

From my point of view rowsMax is here to limit the number of displayed rows, not to limite the actual numbers of rows. I would use another property for this.

Actually, I'm not even sure that we should add this behavior to the core of the TextField. You could easily extend it.

@mbrookes mbrookes added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Jun 3, 2016
@nathanmarks
Copy link
Member

Yeah, that's what this property is for. If you want to limit input you should limit the # of characters in your own application rather than line count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants