Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Add the "emergency" and "id card" icons #41928

Closed
wants to merge 2 commits into from

Conversation

CelestialWorthy
Copy link

@CelestialWorthy CelestialWorthy commented Apr 16, 2024

@CelestialWorthy CelestialWorthy changed the title My topic branch Added Icons Apr 16, 2024
@mui-bot
Copy link

mui-bot commented Apr 16, 2024

Netlify deploy preview

https://deploy-preview-41928--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 443f906

@danilo-leal danilo-leal changed the title Added Icons [icons] Add the "emergency" and "id card" icons Apr 16, 2024
@danilo-leal danilo-leal added new feature New feature or request package: icons Specific to @mui/icons labels Apr 16, 2024
@danilo-leal
Copy link
Contributor

Hey @CelestialWorthy, thanks for the PR, appreciate it! I'll have to close it, though, as I just realized two important things:

  1. The @mui/icons-material is not updated manually this way by adding new SVG files. It's all done via scripts that scrap the icons from the Material Icons set.
  2. The "id card" icon is only available in Material Symbols and not in Material Icons. The icons package only supports the latter, and we don't have plans yet to support the former.

I've opened a PR running the scrips again, which includes at least the Emergency icon.
Thanks again!

@CelestialWorthy
Copy link
Author

Hey @CelestialWorthy, thanks for the PR, appreciate it! I'll have to close it, though, as I just realized two important things:

  1. The @mui/icons-material is not updated manually this way by adding new SVG files. It's all done via scripts that scrap the icons from the Material Icons set.
  2. The "id card" icon is only available in Material Symbols and not in Material Icons. The icons package only supports the latter, and we don't have plans yet to support the former.

I've opened a PR running the scrips again, which includes at least the Emergency icon. Thanks again!

Thank you for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icons] Add the "Id Card" icon [icons] Add the "Emergency" icon
3 participants