Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Skip non React components in visual regressions #41708

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap added the scope: docs-infra Specific to the docs-infra product label Mar 29, 2024
@mui-bot
Copy link

mui-bot commented Mar 29, 2024

Netlify deploy preview

https://deploy-preview-41708--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 07fa568

@bharatkashyap bharatkashyap requested review from alexfauquette and a team and removed request for alexfauquette April 1, 2024 12:22
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work test labels Apr 1, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 1, 2024

I think we should remove some of the files in the blacklist to demonstrate that it works, e.g; getSignInTheme.

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bharatkashyap bharatkashyap merged commit 81ad214 into mui:next Apr 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs-infra] Skip non React components from visual regression tests
5 participants