[Buttons] Address various browser compatibility issues #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmarks
force-pushed
the
enhancedbutton-background-style
branch
from
f3cace8 to
3b85599
Compare
| letterSpacing: 0, | ||
| textTransform: textTransform, | ||
| fontWeight: fontWeight, | ||
| fontSize: fontSize, |
There was a problem hiding this comment.
👍 For moving the fontSize to where it's needed.
| @@ -6,7 +6,7 @@ | |||
| ], | |||
| "env": { | |||
| "test": { | |||
| "sourceMaps": "inline" | |||
| "sourceMaps": "both" | |||
|
@oliviertassinari nice catch!! |
nathanmarks
force-pushed
the
enhancedbutton-background-style
branch
from
3b85599 to
3e919dc
Compare
|
@mbrookes Is this a bug or a regression? 😄 😜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses various browser compatibility issues present in some recent chrome releases (dating back to dec 2015). See #4093 for more details.
I added a test for this particular issue: #4093 (comment)
Some of the CSS may look unnecessary at first glance (or even first test) -- but it took me a fair bit of tinkering to get this working across the different Chrome versions (I checked IE, FF, Safari too).
Here's some screenshots of problems it fixes: